Skip to content

Conversation

@Andy963
Copy link

@Andy963 Andy963 commented Jan 7, 2026

Description

[ What changed? Feel free to be brief. ]

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Fixes undefined title errors and improves resilience when converting JSON Schema to Gemini function schemas. Prevents crashes on missing types and malformed parameters.

  • Bug Fixes
    • Return TYPE_UNSPECIFIED when schema/type is missing or invalid.
    • Remove title mapping; only set description.
    • Detect object/array from properties/items; support type arrays and nullable unions.
    • Validate items/properties before converting; filter anyOf to valid objects.
    • Skip empty object parameters; safer parameter checks.

Written for commit cbbfa0c. Summary will update on new commits.

@Andy963 Andy963 requested a review from a team as a code owner January 7, 2026 14:20
@Andy963 Andy963 requested review from sestinj and removed request for a team January 7, 2026 14:20
@continue-staging
Copy link
Contributor

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

1 similar comment
@continue
Copy link
Contributor

continue bot commented Jan 7, 2026

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@RomneyDa
Copy link
Collaborator

@Andy963 bump on CLA requirement and failing prettier checks!

@Andy963 Andy963 closed this by deleting the head repository Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants